Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick add of base files to new ID67 RGB Matrix variant to allow base compile #15837

Closed
wants to merge 2 commits into from

Conversation

vinorodrigues
Copy link
Contributor

@vinorodrigues vinorodrigues commented Jan 11, 2022

Description

PR #15558 added a RGB Matrix variant to the ID67 code base, by retaining and moving to sub-folders.

This PR add 3 files: id67.h , id67.c, and rules.mk that allow the original make id67 compile command to still work, without the need for specificity of the sub-folder.

(I have tested all three make commands to success.)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

none :(

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@vinorodrigues
Copy link
Contributor Author

Closing / withdrawing this in favour of #15854

@vinorodrigues vinorodrigues deleted the vr-id67-base-fix branch January 12, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant