Relocate matrix_scan_quantum tasks #15882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency for #15722.
Having 2 files which collect the various
_task
s adds unnecessary complexity. While overall behaviour should be mostly the same, with this PR the order will have slightly changed.Before:
matrix_scan_kb
/matrix_scan_user
After:
matrix_scan_kb
/matrix_scan_user
Given how the scan callbacks have little way in interaction with the other tasks, it should be fairly safe to change the order.
Also,
led_matrix_task
would previously be called twice on splitshd44780.h
include removedNote: Future iterations are planned to further sort out the fragmentation shown by the tmk_core+quantum merge.
Types of Changes
Checklist