Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate matrix_scan_quantum tasks #15882

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 15, 2022

Description

Dependency for #15722.

Having 2 files which collect the various _tasks adds unnecessary complexity. While overall behaviour should be mostly the same, with this PR the order will have slightly changed.

Before:

  1. scan matrix
  2. master only tasks
  3. matrix_scan_kb/matrix_scan_user
  4. other tasks

After:

  1. scan matrix
  2. matrix_scan_kb/matrix_scan_user
  3. master only tasks
  4. other tasks

Given how the scan callbacks have little way in interaction with the other tasks, it should be fairly safe to change the order.

Also,

  • led_matrix_task would previously be called twice on splits
  • mid file hd44780.h include removed

Note: Future iterations are planned to further sort out the fragmentation shown by the tmk_core+quantum merge.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 15, 2022 01:53
@zvecr zvecr mentioned this pull request Jan 15, 2022
14 tasks
@tzarc tzarc requested a review from a team January 15, 2022 23:12
@zvecr zvecr merged commit d840ef2 into qmk:develop Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants