-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Allow usage of ChibiOS's SIO driver for split keyboards #15907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
January 20, 2022 16:00
f520d21
to
93b8c44
Compare
github-actions
bot
added
cli
qmk cli command
documentation
keyboard
keymap
python
via
Adds via keymap and/or updates keyboard for via support
labels
Jan 20, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
January 27, 2022 14:36
93b8c44
to
4264889
Compare
github-actions
bot
removed
keymap
via
Adds via keymap and/or updates keyboard for via support
documentation
python
cli
qmk cli command
keyboard
labels
Jan 27, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
February 11, 2022 00:35
4264889
to
9a35d33
Compare
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
March 14, 2022 20:39
9a35d33
to
b866354
Compare
github-actions
bot
added
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
labels
Mar 14, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
March 14, 2022 20:41
b866354
to
e00275d
Compare
github-actions
bot
removed
keyboard
via
Adds via keymap and/or updates keyboard for via support
keymap
labels
Mar 14, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
March 15, 2022 16:44
e00275d
to
f5ea35b
Compare
Updated the docs, this is now ready to be reviewed. |
github-actions
bot
added
keyboard
keymap
python
via
Adds via keymap and/or updates keyboard for via support
labels
Jun 17, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
June 17, 2022 17:58
0ebcbbf
to
cd1da64
Compare
github-actions
bot
removed
cli
qmk cli command
CI
via
Adds via keymap and/or updates keyboard for via support
keyboard
python
keymap
dependencies
labels
Jun 17, 2022
@daskygit as you use G4s on a crkbd could you help verifying that the |
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
June 17, 2022 19:50
cd1da64
to
80122f2
Compare
github-actions
bot
added
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
labels
Jun 17, 2022
KarlK90
force-pushed
the
feature/serial-sio-driver
branch
from
June 17, 2022 19:56
80122f2
to
2c04248
Compare
github-actions
bot
removed
keymap
keyboard
via
Adds via keymap and/or updates keyboard for via support
labels
Jun 17, 2022
daskygit
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some troubleshooting on Discord with Karl it's working well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build upon #16647 while this one is not merged please ignore the commit Use a mutex for split shared memory synchronization in this PR.
Description
Allow usage of 21.11+ ChibiOS's SIO driver for split keyboards. The cool thing about the SERIAL and SIO driver is that both implement the
BaseChannel
interface that provides blocking reading and writing methods that resemble what we already use in the driver. Only some low level aspects like initialization have to be handled differently.Supported Hardware (incomplete)
Every STM32 MCU family that supports
USARTv2
orUSARTv3
like:For test-driving these changes do the following:
config.h
halconf.h
mcuconf.h
Target use-case is the RP2040 which only implements this driver at this point.
Types of Changes
Issues Fixed or Closed by This PR
Checklist