-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple sensors to pmw3360 #15996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't appear to break anything.
You might want to wait for support for different angles as well. It's easy enough to add, but I'm looking for ways to save on space as well. It might end up as an ifdef fest. It's also not sure if this feature will ever see use outside of my build... |
Two sensors, one ball would also allow you to detect twisting around the z-axis (my Kensington SlimBlade does that to trigger scrolling). But dragscroll might be more useful overall. |
- remove unneeded start/stops during the init phase and do only what the data sheet says (more or less). This saves about 50 bytes. - tested on 2 random pmw3360 sensors and a Ploopy mouse - reorder some functions so we don't need to expose them in the header - add an index argument, so that the functions can work on different pins - this adds about 110 bytes again :/ - provide documentation updates on how to use and merge the reports
Thank you for your contribution! |
anti-staleness ping? |
Description
data sheet says (more or less). This saves about 50 bytes.
pins
Types of Changes
Checklist