Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate more makefile utilities to builddefs sub-directory #16002

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Migrate more makefile utilities to builddefs sub-directory #16002

merged 1 commit into from
Feb 10, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 22, 2022 •
edited
Loading

Description

Following on from 14917.

Ignored paths.mk for now, to avoid creating any circular refs....

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Jan 22, 2022
@zvecr zvecr force-pushed the feature/builddefs2 branch from a50fe14 to 5610bd8 Compare February 10, 2022 00:38
@zvecr zvecr marked this pull request as ready for review February 10, 2022 00:39
@zvecr zvecr requested a review from a team February 10, 2022 00:39
Erovia
Erovia approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A simple rebase should resolve the conflict.

@zvecr zvecr force-pushed the feature/builddefs2 branch from 5610bd8 to b768647 Compare February 10, 2022 12:04
@drashna drashna merged commit f7e7671 into qmk:develop Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @Erovia @fauxpark