Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEPROM refactor: remove eeprom_teensy.c by default, use transient instead #16020

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 24, 2022

Description

Default implementation of EEPROM when unspecified was to use a transient-like implementation, implemented in eeprom_teensy.c. This moves the normal implementation to be the actual transient EEPROM implementation, decoupling the implementations further.

All keyboards build, apart from the same two boards currently failing on develop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…d. Removed the equivalent eeprom_teensy fallback.
@tzarc tzarc requested a review from a team January 24, 2022 04:15
@github-actions github-actions bot added the core label Jan 24, 2022
@tzarc tzarc requested a review from zvecr January 24, 2022 04:43
@drashna drashna requested a review from a team January 24, 2022 07:01
@zvecr zvecr merged commit 8f22819 into qmk:develop Jan 24, 2022
@tzarc tzarc deleted the transient-eeprom-by-default branch February 4, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants