Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootloader_jump for certain CTRL boards #16026

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

fauxpark
Copy link
Member

Description

I misread the code here and for some reason reworked it so that all CTRL boards used this "RAM method" instead of tripping the watchdog... which is not correct.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from zvecr January 24, 2022 21:55
@github-actions github-actions bot added the core label Jan 24, 2022
@fauxpark fauxpark requested a review from a team January 24, 2022 21:56
@fauxpark fauxpark added the bug label Jan 24, 2022
@fauxpark fauxpark merged commit c71c0fb into qmk:develop Jan 24, 2022
@fauxpark fauxpark deleted the md-boot-ctrl-fix branch January 24, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants