Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move g heavy industry boards into /gboards #16040

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Conversation

peepeetee
Copy link
Contributor

Description

At this point in my series of board move PRs, I've started to move boards where I cannot reach the makers beforehand, and have to contact them via the PR itself.

This PR is made without contacting(or failing at contacting) @germ first, so it would need them to approve it for it to go in.

As there was no prior communication before this PR, I have to ask a few questions:

  • Is the folder name satisfactory?
  • Did I leave anything out?
  • Did I include anything I shouldn't have included?

One of the reasons I'm electing to do this is to get as many PRs in as possible before the breaking change deadline, please stop me in my tracks if this is inappropriate.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@germ
Copy link
Contributor

germ commented Jan 25, 2022

Apologies for it being hard to track me down. This is all good to go ahead (and thank you for taking care of it!)

@zvecr zvecr requested a review from a team February 11, 2022 22:09
@drashna drashna merged commit 17c0ca6 into qmk:develop Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants