Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move @That-Canadian 's boards into /maple_computing #16050

Merged
merged 2 commits into from
Jan 30, 2022
Merged

move @That-Canadian 's boards into /maple_computing #16050

merged 2 commits into from
Jan 30, 2022

Conversation

peepeetee
Copy link
Contributor

Description

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 26, 2022
@peepeetee peepeetee mentioned this pull request Jan 26, 2022
Closed
@drashna drashna requested a review from a team January 30, 2022 18:57
fauxpark
fauxpark approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, might be worth renaming c39 to collide39, and fixing christmas_tree/V2017 to lowercase.

@drashna drashna merged commit a1b39e6 into qmk:develop Jan 30, 2022
@kuchosauronad0
Copy link
Contributor

I was wondering where my c39 configuration went, fearing it might have been deleted. Thank god it's still there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peepeetee @kuchosauronad0 @drashna @fauxpark