Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise error output. #16220

Merged
merged 2 commits into from
Feb 5, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 5, 2022

Description

Build errors weren't always consistently printing [ERRORS] in the output. qmk multibuild expects this in the output, so this normalises all errors in the QMK-side makefiles to print out in the correct format.

For example:
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team February 5, 2022 01:08
@github-actions github-actions bot added the core label Feb 5, 2022
@tzarc tzarc marked this pull request as ready for review February 5, 2022 01:15
@zvecr zvecr requested a review from a team February 5, 2022 01:28
@daskygit
Copy link
Member

daskygit commented Feb 5, 2022

Weak approval, sorts the issue I was having.

@drashna drashna merged commit e987ce1 into qmk:develop Feb 5, 2022
@tzarc tzarc deleted the add-catastrophic-error-makefile-func branch February 5, 2022 01:33
tzarc added a commit to tzarc/qmk_firmware that referenced this pull request Feb 5, 2022
tzarc added a commit that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants