Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix layer_state restoration at end of dynamic macro feature #16208 #16230

Merged
merged 1 commit into from
Feb 6, 2022
Merged

[Bug] Fix layer_state restoration at end of dynamic macro feature #16208 #16230

merged 1 commit into from
Feb 6, 2022

Conversation

jmdesprez
Copy link

By doing so, methods like 'layer_state_set_user' will be called, ensuring a correct behavior.

Description

This is a fix for #16208.

Restoring the layer state using layer_state = saved_layer_state doesn't call methods like layer_state_set_user leading to strange behavior (like shutting down the leds on the moonlander)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Note regarding tests: the original fix has been made on the zsa fork. A firmware has been build and tested layer_state_set_user is now called two times (from layer 0 then go back to actual layer)

To make this PR I've:

  • checkout the master branch
  • cherry picked the fix
  • make test:all (everything is OK)

By doing so, methods like 'layer_state_set_user' will be called, ensuring a correct behavior.
@github-actions github-actions bot added the core label Feb 5, 2022
@drashna drashna requested a review from a team February 6, 2022 04:20
@drashna drashna changed the title [Fix] Fix layer_state restoration by calling layer_state_set to resolve #16208 [Bug] Fix layer_state restoration at end of dynamic macro feature #16208 Feb 6, 2022
@drashna drashna merged commit 5a0e129 into qmk:develop Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants