Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChibiOS 21.11.1 update. #16251

Merged
merged 9 commits into from
Mar 7, 2022
Merged

ChibiOS 21.11.1 update. #16251

merged 9 commits into from
Mar 7, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 6, 2022 •
edited
Loading

Description

Upgrades to ChibiOS 21.11.1, associated ChibiOS-Contrib.

Needs testing!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team February 6, 2022 22:54
@tzarc tzarc added breaking_change Changes that need to wait for a version increment help wanted needs testing labels Feb 6, 2022
@tzarc tzarc force-pushed the chibios-21.11.1-upgrade branch 2 times, most recently from 543f7bc to 66491b4 Compare February 6, 2022 23:04
@tzarc tzarc marked this pull request as draft February 6, 2022 23:25
@tzarc tzarc force-pushed the chibios-21.11.1-upgrade branch from 66491b4 to 17a78f9 Compare February 7, 2022 05:35
@Xelus22
Copy link
Contributor

Xelus22 commented Feb 7, 2022

Confirmed working on xelus/valor/rev2 and xelus/pachi/rgb/rev2 which both use STM32L422

@tzarc tzarc force-pushed the chibios-21.11.1-upgrade branch from 17a78f9 to a80a6c1 Compare February 7, 2022 06:08
@drashna
Copy link
Member

drashna commented Feb 7, 2022

Has some lint issues.

But tested on a couple blackpills and the proton C, works well.

@tzarc
Copy link
Member Author

tzarc commented Feb 7, 2022

Has some lint issues.

Lint is because a Python file changed in the repo -- it's from upstream so it shouldn't be reformatted anyway. qmk format-python ignores it, regardless.

@drashna drashna mentioned this pull request Feb 26, 2022
Closed
14 tasks
KarlK90
KarlK90 reviewed Mar 1, 2022
View reviewed changes
builddefs/bootloader.mk Outdated Show resolved Hide resolved
@tzarc tzarc marked this pull request as ready for review March 4, 2022 01:26
@tzarc
Copy link
Member Author

tzarc commented Mar 4, 2022

Lint CI action fails due to util/uf2conv.py -- it shouldn't be formatted so that it matches upstream.

@tzarc
Copy link
Member Author

tzarc commented Mar 4, 2022

Looks like something breaks building when targeting RISC-V for the GD32VF103. Investigating.

@tzarc tzarc force-pushed the chibios-21.11.1-upgrade branch 2 times, most recently from e69c6cd to d51c505 Compare March 4, 2022 04:31
@tzarc tzarc force-pushed the chibios-21.11.1-upgrade branch from d51c505 to fb4da91 Compare March 4, 2022 04:32
@KarlK90
Copy link
Member

KarlK90 commented Mar 4, 2022

Looks like something breaks building when targeting RISC-V for the GD32VF103. Investigating.

I can confirm that the build issues have been fixed using the standard Debian GCC 10 toolchain with picolibc.

@tzarc
Copy link
Member Author

tzarc commented Mar 5, 2022 •
edited
Loading

Looks good to go, now. Future ChibiOS-Contrib updates on the 21.11.x branch (for things like RP2040) can follow afterward.

@drashna drashna requested a review from a team March 7, 2022 03:25
@tzarc tzarc merged commit 44f1bd9 into qmk:develop Mar 7, 2022
@tzarc tzarc deleted the chibios-21.11.1-upgrade branch March 7, 2022 10:04
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Mar 23, 2022
@tzarc @waffle87
ChibiOS 21.11.1 update. (qmk#16251)
1201473 
* ChibiOS 21.11.1 update.

* `uf2-tinyuf2` => `tinyuf2`

* Updated chibios-contrib, fixup preprocessor for tinyuf2 bootloader.

* Fixup keychron L433 boards.

* Makefile cleanup.

* RISC-V build fixes.

* Fixup RISC-V build.
@trwnh trwnh mentioned this pull request May 30, 2022
Closed
3 tasks
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@tzarc @zykrah
ChibiOS 21.11.1 update. (qmk#16251)
3d7fae8 
* ChibiOS 21.11.1 update.

* `uf2-tinyuf2` => `tinyuf2`

* Updated chibios-contrib, fixup preprocessor for tinyuf2 bootloader.

* Fixup keychron L433 boards.

* Makefile cleanup.

* RISC-V build fixes.

* Fixup RISC-V build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core dependencies help wanted keyboard needs testing python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @Xelus22 @drashna @KarlK90