Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for matrix _RIGHT handling #16292

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Various fixes for matrix _RIGHT handling #16292

merged 2 commits into from
Feb 11, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 10, 2022 •
edited
Loading

Description

#16287 (comment)

The main issue, matrix_init_pins within DIRECT_PINS iterates double what it should on splits.

Remaining changes are to avoid using arrays double the required size.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Feb 10, 2022
@zvecr zvecr requested a review from a team February 10, 2022 00:58
@github-actions github-actions bot added the core label Feb 10, 2022
@zvecr zvecr mentioned this pull request Feb 10, 2022
Merged
14 tasks
@zvecr zvecr marked this pull request as ready for review February 10, 2022 01:24
@zvecr zvecr changed the base branch from master to develop February 11, 2022 18:56
@zvecr zvecr force-pushed the feature/ROWS_PER_HAND_fixes branch from 2fe9fca to 1e7bcb9 Compare February 11, 2022 18:56
@zvecr zvecr merged commit 39bec3b into qmk:develop Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @fauxpark @KarlK90