Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'helix/rev2:default' setting to use split_common #16432

Merged
merged 14 commits into from
Mar 2, 2022

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Feb 22, 2022

Description

Changed the following Helix keymaps to use split_common.

  • default
  • five_rows
  • led_test

The following Helix keymaps isn't ready to use split_common, so use the same local custom implementation as before.
In this PR, there is no change in the binary of the build result of the following keymap.

  • edvorakjp
  • five_rows_jis
  • fraanrosi
  • yshrsmz
  • froggy
  • froggy_106

@MakotoKurauchi, This PR needs your review and approval.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Feb 22, 2022

Modifying user keymaps on master needs user sign off (strictly speaking this should have also happened on 16418). Compiling to the same binary is not enough to skip this, as its the change to the files that is the issue.

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Feb 22, 2022
@mtei
Copy link
Contributor Author

mtei commented Feb 22, 2022

For the keymaps 'five_rows_jis', 'fraanrosi', 'yshrsmz', 'froggy' and 'froggy_106'

  • 'keymap.c'
    I have not made any changes.
  • 'rules.mk'
    Added a setting to cancel changes to default settings made in 'helix/rev2/rules.mk'.
    This was done so as not to change the build result.

@zvecr
Copy link
Member

zvecr commented Feb 22, 2022

Not the point. User files include rules.mk and have been modified by a third party.

https://docs.qmk.fm/#/contributing?id=general-guidelines

IMPORTANT: If you would like to contribute a bugfix or improvement to user code, such as non-default keymaps, userspace and layouts, be sure to tag the original submitter of the code in your PR. Many users, regardless of skill level with Git and GitHub, may be confused or frustrated at their code being modified without their knowledge.

Again, the fact the build result hasnt changed, isnt enough to skip notifying users.

@zvecr zvecr changed the base branch from master to develop February 22, 2022 16:26
@mtei mtei changed the title Change helix/rev2 default setting to use split_common Change 'helix/rev2:default' setting to use split_common Feb 22, 2022
@mtei
Copy link
Contributor Author

mtei commented Feb 22, 2022

OKey.
Canceled all keymap changes except for default and my five_rows, led_test.

@mtei mtei changed the base branch from develop to master February 22, 2022 17:20
@mtei mtei removed the breaking_change Changes that need to wait for a version increment label Feb 22, 2022
@drashna drashna requested a review from a team February 27, 2022 01:43
@mtei mtei merged commit e73f8e9 into qmk:master Mar 2, 2022
@mtei mtei deleted the helixrev2_set_default_split_common branch April 22, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants