-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'helix/rev2:default' setting to use split_common #16432
Conversation
…froggy, froggy_106, yshrsmz
Modifying user keymaps on master needs user sign off (strictly speaking this should have also happened on 16418). Compiling to the same binary is not enough to skip this, as its the change to the files that is the issue. |
For the keymaps 'five_rows_jis', 'fraanrosi', 'yshrsmz', 'froggy' and 'froggy_106'
|
Not the point. User files include https://docs.qmk.fm/#/contributing?id=general-guidelines
Again, the fact the build result hasnt changed, isnt enough to skip notifying users. |
OKey. |
Description
Changed the following Helix keymaps to use split_common.
The following Helix keymaps isn't ready to use split_common, so use the same local custom implementation as before.In this PR, there is no change in the binary of the build result of the following keymap.
edvorakjpfive_rows_jisfraanrosiyshrsmzfroggyfroggy_106@MakotoKurauchi, This PR needs your review and approval.
Types of Changes
Issues Fixed or Closed by This PR
Checklist