Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wb32-dfu #16438

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Update wb32-dfu #16438

merged 3 commits into from
Apr 19, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Feb 23, 2022 •
edited
Loading

Description

Since bootloader.mk adds BOOTLOADER_TYPE but does not add WB32-DFU related to BOOTLOADER_TYPE, I submit this PR hoping that it can be combined in 2022q1.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 23, 2022
@itarze itarze changed the title Updte builddefs/bootloader.mk Update wb32-dfu Feb 23, 2022
@drashna drashna requested a review from a team February 23, 2022 08:36
@itarze
Copy link
Contributor Author

itarze commented Feb 23, 2022

Why can't you merge in 2022q1.

@fauxpark
Copy link
Member

You missed the cutoff.
https://docs.qmk.fm/#/breaking_changes?id=important-dates

@itarze
Copy link
Contributor Author

itarze commented Feb 23, 2022

All right, I should have noticed this sooner.

@drashna
Copy link
Member

drashna commented Feb 23, 2022

Also, master is locked today. So that's a "hard miss".

@itarze
Copy link
Contributor Author

itarze commented Mar 14, 2022

Could this PR be merged as soon as possible? I have a keyboard and need it.

@drashna drashna requested a review from a team April 13, 2022 06:00
@tzarc tzarc merged commit 25f849b into qmk:develop Apr 19, 2022
@itarze itarze deleted the flash_spi branch April 20, 2022 02:04
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zykrah
Update wb32-dfu (qmk#16438)
5f921ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itarze @fauxpark @drashna @tzarc