Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 1k USB_POLLING_INTERVAL_MS config from keyboards and default-ish keymaps #16448

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Remove 1k USB_POLLING_INTERVAL_MS config from keyboards and default-ish keymaps #16448

merged 2 commits into from
Feb 26, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 26, 2022 •
edited
Loading

Description

Default is now 1k so setting it again is pointless. User code can stay as is till someone does the same changes via develop.

(Also a few of the touched files didnt have #pragma once guards so added them at the same time)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 26, 2022
@zvecr zvecr requested a review from a team February 26, 2022 03:12
@zvecr zvecr merged commit 83a32b2 into qmk:master Feb 26, 2022
hongaaronc added a commit to hongaaronc/qmk_firmware that referenced this pull request Feb 27, 2022
@hongaaronc
Remove 1k USB_POLLING_INTERVAL_MS config
03db9e1 
Since 1k is now already defaulted for all QMK boards, it is redundant here. See for reference: qmk#16448
@andrebrait
Copy link
Contributor

andrebrait commented Oct 5, 2022 •
edited
Loading

@zvecr any chance this could influence this?

qmk_firmware/tmk_core/protocol/arm_atsam/usb/udi_device_conf.h

Line 27 in 63646e8

# define USB_POLLING_INTERVAL_MS 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap optimization via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @andrebrait @drashna