atlas_65 Layout Macro Refactor #16483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert tabs to spaces - four-space indent - align backslashes in layout macro
Visually separates each side. White-space-only change.
Move the matrix position identifiers in the layout macro to resemble the assembled keyboard's layout. - move `k46` (right side B) to the fourth (Shift) row - move each of `k1E`, `k2E` and `k3E` (right side navigation keys) up one row - update keymaps to match
Update the maintainer data in `info.json` and `readme.md`.
noroadsleft
added
enhancement
keyboard
keymap
via
drashna
approved these changes
Mar 1, 2022
fauxpark
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flagged by /u/worldofindie on Reddit:
Programming works correctly when compiled from source, but out of sequence in Configurator.
Refactored the source because the Configurator data is as would be expected if the source conformed to QMK guidelines.
cc @ryanstevensmith (keyboard maintainer)
Types of Changes
Checklist