Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFK78 VIA support and Updated to compile to the latest QMK #16502

Merged
merged 3 commits into from
Mar 7, 2022
Merged

LFK78 VIA support and Updated to compile to the latest QMK #16502

merged 3 commits into from
Mar 7, 2022

Conversation

nayoshi
Copy link

@nayoshi nayoshi commented Mar 3, 2022

Description

Fixed LFK78 firmware to be able to compile in the latest version of QMK. Added VIA support to LFK78.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Changed Vendor ID to 0x4C46 = LF
  • Changed Product ID to 0x3738 = 78
  • Added VIA keymap to LFK78
  • Changed function name from click to clickingNotes (As click is a qmk variable and throws error when compiled)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 3, 2022
@nayoshi nayoshi mentioned this pull request Mar 3, 2022
Merged
6 tasks
drashna
drashna reviewed Mar 7, 2022
View reviewed changes
keyboards/lfkeyboards/lfk78/lfk78.c Outdated Show resolved Hide resolved
keyboards/lfkeyboards/lfk78/lfk78.c Outdated Show resolved Hide resolved
keyboards/lfkeyboards/lfk78/lfk78.h Outdated Show resolved Hide resolved
@nayoshi nayoshi requested a review from drashna March 7, 2022 05:15
@drashna drashna requested a review from a team March 7, 2022 06:57
@drashna drashna merged commit 2ff646c into qmk:master Mar 7, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@nayoshi @zykrah
[Keyboard] LFK78 VIA support and Update (qmk#16502)
79530d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayoshi @drashna @fauxpark