Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new-keyboard bootmagic setting #16540

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Fix new-keyboard bootmagic setting #16540

merged 1 commit into from
Mar 5, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 5, 2022

Description

bootmagic_lite is no longer a valid option, no validation of keys in this area allowed this to slip through on the recent rewwork.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team March 5, 2022 20:55
@zvecr zvecr added the bug label Mar 5, 2022
@tzarc tzarc merged commit b202e59 into master Mar 5, 2022
@zvecr zvecr deleted the fix_template_bootmagic branch July 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants