Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo workaround for pin_def errors on KINETIS #16620

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 11, 2022

Description

Wow this stuff is fragile....

Dislike the platform specific bodge, and will try and revisit this mess in the future to fix this include order mess.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 11, 2022
@zvecr zvecr requested a review from a team March 11, 2022 15:58
@github-actions github-actions bot added the core label Mar 11, 2022
@zvecr zvecr force-pushed the feature/fix_pin_defs2 branch from 9a2929a to 5460974 Compare March 11, 2022 16:14
@drashna drashna requested a review from a team March 11, 2022 18:45
@zvecr zvecr merged commit dd32cdf into qmk:develop Mar 11, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
* Redo workaround for pin_def errors on KINETIS

* Redo workaround for pin_def errors on KINETIS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants