Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Bump the 'jsonschema' version #16635

Merged
merged 2 commits into from
Apr 6, 2022
Merged

CLI: Bump the 'jsonschema' version #16635

merged 2 commits into from
Apr 6, 2022

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Mar 13, 2022

Description

Bump the installed version of jsonschema to >=4 so we have access to the validator of the latest meta-schema.
As we already request >=3, installations after 2021-11-30 should satisfy the new requirements.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia
CLI: Bump the 'jsonschema' version
e73b50f 
Update the used meta-schema from Draft 7 from 2018 to the latest one,
Draft 2020-12.
Currently, the validator falls back to Draft 7 if the newer validator is
not available. Draft 2020-12 support was introduced to 'jsonschema' in
version 4.0.0.
@github-actions github-actions bot added cli qmk cli command python labels Mar 13, 2022
@Erovia Erovia requested a review from a team March 13, 2022 17:42
@zvecr zvecr merged commit 85de020 into qmk:develop Apr 6, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Erovia @zykrah
CLI: Bump the 'jsonschema' version (qmk#16635)
4fab0d5 
* CLI: Bump the 'jsonschema' version

Update the used meta-schema from Draft 7 from 2018 to the latest one,
Draft 2020-12.
Currently, the validator falls back to Draft 7 if the newer validator is
not available. Draft 2020-12 support was introduced to 'jsonschema' in
version 4.0.0.

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erovia @fauxpark @zvecr