Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helix/rev2 move to split common #16723

Merged
merged 5 commits into from
Apr 21, 2022
Merged

Helix/rev2 move to split common #16723

merged 5 commits into from
Apr 21, 2022

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Mar 24, 2022 •
edited
Loading

Description

  • Switch the Helix default setting to use split_common.
  • remove the previous implementation.

@MakotoKurauchi, This PR needs your review and approval.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei mentioned this pull request Mar 24, 2022
Closed
@mtei mtei force-pushed the helixrev2_move_to_split_common branch from 3127fd3 to b42b387 Compare April 11, 2022 09:23
@mtei mtei force-pushed the helixrev2_move_to_split_common branch from b42b387 to 9c89495 Compare April 20, 2022 12:10
@mtei mtei changed the title [WIP] Helix/rev2 move to split common Helix/rev2 move to split common Apr 20, 2022
@mtei mtei marked this pull request as ready for review April 20, 2022 12:10
@mtei mtei requested a review from a team April 20, 2022 12:11
@mtei
Copy link
Contributor Author

mtei commented Apr 21, 2022 •
edited
Loading

Current Status

make helix:all, make helix/rev2:all

This command fails with the five_rows keymap.
I created PR #16847 because it is a local problem with the five_rows keymap.

make helix/rev2/back:all

This command exits normally.
This PR checked the operation using the binary created by this command and found no abnormalities.

@drashna drashna merged commit 8f692e2 into qmk:develop Apr 21, 2022
@mtei mtei deleted the helixrev2_move_to_split_common branch April 22, 2022 13:59
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@mtei @zykrah
Helix/rev2 move to split common (qmk#16723)
12127e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@MakotoKurauchi MakotoKurauchi MakotoKurauchi approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtei @drashna @tzarc @MakotoKurauchi @fauxpark