Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup AVR builds. #16875

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Fixup AVR builds. #16875

merged 2 commits into from
Apr 18, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 18, 2022

Description

Fixes a problem with #16869.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from zvecr and a team April 18, 2022 11:46
fauxpark
fauxpark requested changes Apr 18, 2022
View reviewed changes
platforms/avr/hardware_id.c Outdated Show resolved Hide resolved
@zvecr @fauxpark
Update platforms/avr/hardware_id.c
f158c06 
Co-authored-by: Ryan <fauxpark@gmail.com>
@zvecr zvecr merged commit f50a623 into qmk:develop Apr 18, 2022
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Apr 18, 2022
Merge remote-tracking branch 'qmk/develop' into develop
7d0a70e 
* qmk/develop:
  Preinstall python dependencies before executing `qmk`. (qmk#16874)
  Fixup AVR builds. (qmk#16875)
@tzarc tzarc deleted the fixup-hardware-ids branch April 19, 2022 08:53
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@tzarc @zvecr
@fauxpark @zykrah
Fixup AVR builds. (qmk#16875)
c7ce29d 
* Fixup AVR builds.

* Update platforms/avr/hardware_id.c

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr zvecr approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @fauxpark @KarlK90 @zvecr