Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPI support for the OLED Driver #16924

Closed
wants to merge 3 commits into from
Closed

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Apr 23, 2022

Description

Replace all i2c calls to generic functions that can call the SPI or I2C drivers accordingly.

If using SPI the user will need to define the Chip Select pin, Data/Command pin and optionally the Reset pin, they must configure their board's SPI Master driver to be used with this new addition.

Still needs to be tested with AVR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Jpe230
Copy link
Contributor Author

Jpe230 commented Apr 23, 2022

This will live as a Draft in favor of a proper implementation in Quantum Painter.

@drashna drashna requested a review from a team April 24, 2022 01:52
@drashna
Copy link
Member

drashna commented May 10, 2023

Sorry, I missed this. However, #20331 also added this, and was tested with AVR and PROGMEM.

@drashna drashna closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants