Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joystick: Simplify report descriptor and clean up error messages #16926

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 24, 2022

Description

The report descriptor can be simplified here by replacing the individual Usage items with Usage Minimum and Usage Maximum and limiting the number of axes/buttons able to be defined.

Windows refused to recognise the game controller interface, although it was labelled as such in Device Manager, and Wireshark also understood it...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 24, 2022 00:11
@fauxpark fauxpark changed the title Joystick: Simplify report descriptor for axes and clean up error messages Joystick: Simplify report descriptor and clean up error messages Apr 24, 2022
@drashna drashna requested a review from a team April 24, 2022 02:11
@fauxpark fauxpark merged commit 645359e into qmk:develop Apr 25, 2022
@fauxpark fauxpark deleted the joystick-descriptor-and-errors branch April 25, 2022 22:54
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants