Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move disable_jtag to platforms #16960

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Move disable_jtag to platforms #16960

merged 1 commit into from
Apr 29, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 28, 2022 •
edited
Loading

Description

Removes more platform specific ifdef logic from core, while maintaining the existing order of events.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team April 28, 2022 21:25
@github-actions github-actions bot added the core label Apr 28, 2022
@drashna drashna requested a review from a team April 28, 2022 21:47
@zvecr zvecr merged commit d458d4a into qmk:develop Apr 29, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @zykrah
Move disable_jtag to platforms (qmk#16960)
ba31c32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark