Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup checkerboards/quark_lp #17008

Closed
wants to merge 2 commits into from
Closed

Fixup checkerboards/quark_lp #17008

wants to merge 2 commits into from

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented May 5, 2022 •
edited
Loading

Description

  • RGB_MATRIX_DRIVER was undefined.
  • g_led_config was incorrect according to MATRIX_ROWS/MATRIX_COLS definitions. (I assume excess LEDs defined are underglow)
  • Other misc. stuff.

@npspears look ok?

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 5, 2022
@fauxpark fauxpark requested a review from a team May 5, 2022 03:59
@npspears
Copy link
Contributor

npspears commented May 5, 2022

No, please keep those extra LEDs. There is not underglow on this PCB. The extra LEDs are because of the extra keys on the bottom row (grid, single 2u, 2x2u)

@waffle87
Copy link
Member Author

waffle87 commented May 5, 2022

No, please keep those extra LEDs. There is not underglow on this PCB. The extra LEDs are because of the extra keys on the bottom row (grid, single 2u, 2x2u)

Their functionality will be retained with the positions defined here, but the first array in g_led_config needs to match the matrix row/col number. However, those positional values may want to be changed, given that the LEDs for the other layouts are now 48, 49, & 50. Hope that makes sense.

@npspears
Copy link
Contributor

npspears commented May 5, 2022

I might understand, but I also don't know what the solution is. Please chat with me on Discord if you can. I'll be on tomorrow morning.

@npspears npspears mentioned this pull request May 5, 2022
Merged
9 tasks
@npspears
Copy link
Contributor

npspears commented May 6, 2022

Just confirming that I talked to Jack on Discord and I have verified the 3 "extra" LEDs. Thanks for the help!

@npspears
Copy link
Contributor

what else do you need from me to in order to see this pushed?

@waffle87 waffle87 closed this May 17, 2022
@waffle87 waffle87 deleted the fix/checkerboards_quarklp branch May 17, 2022 19:29
@waffle87 waffle87 restored the fix/checkerboards_quarklp branch May 21, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @npspears @fauxpark