Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish data as part of API generation #17020

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Publish data as part of API generation #17020

merged 3 commits into from
Aug 6, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 6, 2022 •
edited
Loading

Description

Prep for #15597.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team May 6, 2022 18:24
@zvecr zvecr changed the title Publish data as part of API gen Publish data as part of API generation May 6, 2022
@github-actions github-actions bot added CI cli qmk cli command python labels May 6, 2022
@zvecr zvecr force-pushed the feature/publish_data branch from 1e60d50 to 933f086 Compare May 6, 2022 21:23
KarlK90
KarlK90 approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/api.yml Outdated Show resolved Hide resolved
@zvecr zvecr requested review from a team and KarlK90 May 7, 2022 19:33
@tzarc tzarc merged commit 897403c into qmk:develop Aug 6, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Publish data as part of API generation (qmk#17020)
f68d5bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@KarlK90 KarlK90 Awaiting requested review from KarlK90

Assignees
No one assigned
Labels
CI cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @KarlK90