Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Rename IDOBAO ID80 "v1" to "v2" to clear up confusion #17137

Closed
wants to merge 15 commits into from
Closed

[Keyboard] Rename IDOBAO ID80 "v1" to "v2" to clear up confusion #17137

wants to merge 15 commits into from

Conversation

vinorodrigues
Copy link
Contributor

Description

IDOBAO support has received a few support calls with developers confused with the "v1" name used in the folder structure introduced in #15992.

The code in the v1 folder is perfectly suited to the current v2 boards and correct naming will prevent developers from inadvertently using v3 codebase in their v2 boards.

This PR seeks to rename the "v1" folder to "v2" (to eliminate confusion), and then add a readme.md and rules.mk file to the "v1" (ensuring backward compatibility).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 17, 2022
@vinorodrigues vinorodrigues mentioned this pull request May 17, 2022
Closed
14 tasks
@vinorodrigues
Copy link
Contributor Author

Redo of #17054. (Sorry, I @#$%ed-up the rebase on that one.)

@vinorodrigues vinorodrigues changed the title [keyboard] rename id80 v1 to v2 to clear up confusion [Keyboard] Rename IDOBAO ID80 "v1" to "v2" to clear up confusion May 29, 2022
@vinorodrigues
Copy link
Contributor Author

why does this keep pulling external commits?

@vinorodrigues vinorodrigues deleted the vr-id80-v1-rename branch May 29, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinorodrigues @tzarc @qmk-bot @waffle87 @zvecr