[Keyboard] Add Hillside 52 #17374

mmccoyd · 2022-06-13T02:26:31Z

Description

Add Hillside 52 with default.json .c and via keymaps. https://github.com/mmccoyd/hillside

The handwired/hillside/readme has a link to where the 48 keyboard will be once approved PR #17210, renaming Hillside 0_1 to Hillside 48, is merged. Until then it is a broken link.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- Change script rows

CAPSWORD, QK_BOOT, readme cleanup, EE_RST

- Del in backspace spot on sym layer - Thumb shift OSM instead of extra space - Nav/edit on num/fn: arrows cut copy paste undo redo, page up/down - Fn keys bottom row to allow nav edit keys - App and AltGr on lower row, on their layer - Braces on index, so more common -= on middle ring. - Adjust has Ctrl/GUI swap - EE_RST, CAPSWORD, QK_BOOT, SPLIT_DETECT

- .json: vid: MM, pid: H52

- CAPSWRD instead of ANY, though config.qmk still converts to ANY()

keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c

keyboards/handwired/hillside/52/keymaps/json2hill52.py

keyboards/handwired/hillside/52/readme.md

Co-authored-by: Drashna Jaelre <drashna@live.com>

keyboards/handwired/hillside/readme.md

Co-authored-by: Drashna Jaelre <drashna@live.com>

mmccoyd · 2022-07-02T21:30:19Z

Sorry I missed that.

mmccoyd · 2022-07-15T19:07:52Z

Keymap has caps word on a layer.
Rebase to master HEAD. Also checked convert to 2040 over on dev.

- Nav: - Arrows on right so up/down more intuitive. Page up/down on ends - Cut on home row, as more common - Sym: - Layer mods on activate hand, extras symbols on left - Common digits on lower row - Base: - Layer keys symmetric, on most extended, not resting, thumb - Mute on util key for easy use - Swap layers 3 and 4 to match swapped thumbs

keyboard-magpie · 2022-08-07T19:58:55Z

Any particular reason this in in handwired

mmccoyd · 2022-08-08T20:04:20Z

My reading of QMK guidelines was that boards not in commercial production went in handwired. Whether they were PCB or actually handwired. So I put the original hillside there.

keyboard-magpie · 2022-08-13T16:17:12Z

My reading of QMK guidelines was that boards not in commercial production went in handwired. Whether they were PCB or actually handwired. So I put the original hillside there.

This is fairly old dogma, nowadays any keyboard with a PCB is welcome in the main repository- will leave this for now but could be a future PR for you.

mmccoyd · 2022-08-13T16:28:35Z

Thanks for the review! Once they all settle I'll do a PR to move up out of handwired.

mmccoyd · 2022-08-13T16:46:24Z

This is fairly old dogma, nowadays any keyboard with a PCB is welcome in the main repository- will leave this for now but could be a future PR for you.

Would setting up a move PR now be less disruptive?
There are still two hillside PRs in flight. A merged to dev breaking change rename of 0_1 to 48, and an addition of Hillside 46.
My guess is that after those complete would be best.

keyboard-magpie · 2022-08-13T18:56:16Z

Would suggest after this current/impending breaking changes cycle.

* 52 Keymap.json: Set for Hillside 52 - Change script rows * 52 Keymap.c: mirror .json CAPSWORD, QK_BOOT, readme cleanup, EE_RST * 52 Keymap.json: Initial files copy from 56 * 52 Keymap.json nav/edit lay, thumb shift, syms - Del in backspace spot on sym layer - Thumb shift OSM instead of extra space - Nav/edit on num/fn: arrows cut copy paste undo redo, page up/down - Fn keys bottom row to allow nav edit keys - App and AltGr on lower row, on their layer - Braces on index, so more common -= on middle ring. - Adjust has Ctrl/GUI swap - EE_RST, CAPSWORD, QK_BOOT, SPLIT_DETECT * 52 Family: readme image and folder link * 52 Board: initial copy from 56 * 52 Keymap via * 52 Board: remove keys, cant columns, better ids - .json: vid: MM, pid: H52 * 52 Keymap.c: initial.c copy from 48 * QK_BOOT EE_CLR, not ANY(), as config.qmk supports - CAPSWRD instead of ANY, though config.qmk still converts to ANY() * Cleanup readme * 52 Keymap: Remove redundant key, cleanup script * 52 Keymap: Fix template * 52 Readme: Link lower res image better for readme Co-authored-by: Drashna Jaelre <drashna@live.com> * 52 Keymap: Move pretty-print script to GitHub wiki * 52 Keymap: Link to 1024 res image thumbnails * 52 Keymap: fix whitespace before image link * Family: Fix image link to 1024 thumb Co-authored-by: Drashna Jaelre <drashna@live.com> * 52: Keymap: Caps word on a layer home row * 52: Keymap: Arrows on right. Symmetric layer keys. - Nav: - Arrows on right so up/down more intuitive. Page up/down on ends - Cut on home row, as more common - Sym: - Layer mods on activate hand, extras symbols on left - Common digits on lower row - Base: - Layer keys symmetric, on most extended, not resting, thumb - Mute on util key for easy use - Swap layers 3 and 4 to match swapped thumbs Co-authored-by: mmccoyd <mmccoyd@cs.berkley.edu> Co-authored-by: Drashna Jaelre <drashna@live.com>

mmccoyd added 9 commits April 11, 2022 22:12

52 Keymap.json: Set for Hillside 52

5cab58b

- Change script rows

52 Keymap.c: mirror .json

63114c3

CAPSWORD, QK_BOOT, readme cleanup, EE_RST

52 Keymap.json: Initial files copy from 56

b564dec

52 Family: readme image and folder link

ad137bb

52 Board: initial copy from 56

b87064c

52 Keymap via

3fc1e1d

52 Board: remove keys, cant columns, better ids

ca9332e

- .json: vid: MM, pid: H52

52 Keymap.c: initial.c copy from 48

febb42f

github-actions bot added keyboard keymap python via Adds via keymap and/or updates keyboard for via support labels Jun 13, 2022

mmccoyd marked this pull request as ready for review June 13, 2022 03:07

mmccoyd added 4 commits June 14, 2022 14:29

QK_BOOT EE_CLR, not ANY(), as config.qmk supports

6c97a4d

- CAPSWRD instead of ANY, though config.qmk still converts to ANY()

Cleanup readme

c66cc59

52 Keymap: Remove redundant key, cleanup script

7c581bf

52 Keymap: Fix template

fdd3630

drashna reviewed Jun 21, 2022

View reviewed changes

keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c Show resolved Hide resolved

drashna reviewed Jun 21, 2022

View reviewed changes

keyboards/handwired/hillside/52/keymaps/json2hill52.py Outdated Show resolved Hide resolved

drashna reviewed Jun 21, 2022

View reviewed changes

keyboards/handwired/hillside/52/readme.md Outdated Show resolved Hide resolved

52 Readme: Link lower res image better for readme

f36f424

Co-authored-by: Drashna Jaelre <drashna@live.com>

drashna requested a review from a team June 22, 2022 05:10

mmccoyd added 2 commits June 22, 2022 14:35

52 Keymap: Move pretty-print script to GitHub wiki

7a67418

52 Keymap: Link to 1024 res image thumbnails

94b817f

github-actions bot removed the python label Jun 23, 2022

mmccoyd force-pushed the hill52 branch from a9700a4 to 69183c5 Compare June 23, 2022 02:47

52 Keymap: fix whitespace before image link

a9a24a4

mmccoyd requested a review from drashna July 2, 2022 02:28

drashna reviewed Jul 2, 2022

View reviewed changes

keyboards/handwired/hillside/readme.md Outdated Show resolved Hide resolved

Family: Fix image link to 1024 thumb

f236472

Co-authored-by: Drashna Jaelre <drashna@live.com>

mmccoyd requested a review from drashna July 2, 2022 22:10

drashna approved these changes Jul 11, 2022

View reviewed changes

drashna requested a review from a team July 11, 2022 19:54

mmccoyd marked this pull request as draft July 12, 2022 16:13

52: Keymap: Caps word on a layer home row

9a8ecfd

mmccoyd force-pushed the hill52 branch 2 times, most recently from 1b67521 to 9a8ecfd Compare July 15, 2022 19:00

mmccoyd marked this pull request as ready for review July 15, 2022 19:08

mmccoyd marked this pull request as draft July 24, 2022 07:32

mmccoyd marked this pull request as ready for review July 27, 2022 02:00

drashna approved these changes Aug 9, 2022

View reviewed changes

drashna requested a review from a team August 9, 2022 18:16

keyboard-magpie approved these changes Aug 13, 2022

View reviewed changes

keyboard-magpie merged commit 0c0d019 into qmk:master Aug 13, 2022

mmccoyd deleted the hill52 branch August 13, 2022 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add Hillside 52 #17374

[Keyboard] Add Hillside 52 #17374

mmccoyd commented Jun 13, 2022

mmccoyd commented Jul 2, 2022

mmccoyd commented Jul 15, 2022 •

edited

Loading

keyboard-magpie commented Aug 7, 2022

mmccoyd commented Aug 8, 2022 •

edited

Loading

keyboard-magpie commented Aug 13, 2022

mmccoyd commented Aug 13, 2022

mmccoyd commented Aug 13, 2022

keyboard-magpie commented Aug 13, 2022

[Keyboard] Add Hillside 52 #17374

[Keyboard] Add Hillside 52 #17374

Conversation

mmccoyd commented Jun 13, 2022

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

mmccoyd commented Jul 2, 2022

mmccoyd commented Jul 15, 2022 • edited Loading

keyboard-magpie commented Aug 7, 2022

mmccoyd commented Aug 8, 2022 • edited Loading

keyboard-magpie commented Aug 13, 2022

mmccoyd commented Aug 13, 2022

mmccoyd commented Aug 13, 2022

keyboard-magpie commented Aug 13, 2022

mmccoyd commented Jul 15, 2022 •

edited

Loading

mmccoyd commented Aug 8, 2022 •

edited

Loading