[BUG] Fix deadlocks on disconnected secondary half #17423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a deadlock bug that sneaked in with #16669. It can only be triggered on a secondary half that is not connected to the main usb connected half, thus not receiving any handshake packets. Which should be a edge-case e.g. when updating one half but still...
The problematic code that could trigger the deadlock
And now in
transactions_slave()
the Mutex is acquired again.Because manually locking and unlocking can be quite error prone, I added support for RAII-style mutex guards
split_shared_memory_lock_autounlock
that can be used in addition to the already existinglock
/unlock
functions. Unfortunately GCCcleanup
attribute always wants a cleanup function with a pointer variable, so some unsexy function wrapping was necessary.Types of Changes
Issues Fixed or Closed by This PR
Checklist