Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature_split_keyboard.md to add extra detail about left and right matrices. #17492

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

ihatechoosingusernames
Copy link

This sentence would've saved me about four hours of frustration with my hand-wired split!

Hopefully it helps someone else.

Description

Described the requirements for defining split matrices in more detail, noted that left and right hands must have equal numbers of rows, and that unneeded spaces in the pin definitions must be padded with NO_PIN.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This sentence would've saved me about four hours of frustration with my hand-wired split!

Hopefully it helps someone else.
@drashna drashna requested a review from a team June 29, 2022 08:30
@tzarc tzarc merged commit 1204cbb into qmk:develop Jun 29, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants