Allow for keymaps array to be implemented in a file other than $(KEYMAP_C)
#17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jul 4, 2022
tzarc
force-pushed
the
allow-non-keymap_c-introspection
branch
from
4a7cd50 to
c29da06
Compare
|
Hopefully addresses instances like the followup comments on #17229. |
|
TBH I'm not 100% convinced that allowing this aligns with the data driven direction in the first place. Just my 2c. |
|
This worked for me, thank you |
100% agree, but right now the introspection breaks things written that way. We're kicking the can down the road while we sort out DD. |
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some weird keymap generation going on with the miryoku keymaps -- they weren't actually part of the normal
keymap.cfile, but rather specified elsewhere.This adds the ability to specify a different file to include into the introspection code.
Types of Changes
Checklist