Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pro Micro SDA/SCL pinout for PM2040 #17595

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Use Pro Micro SDA/SCL pinout for PM2040 #17595

merged 1 commit into from
Jul 20, 2022

Conversation

filterpaper
Copy link
Contributor

Description

Refactor #17578 to use Pro Micro pinout instead. This will allow wider converter support for RP2040 boards such as Blok that uses different GPIO pins for SDA and SCL.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 8, 2022
@zvecr zvecr requested a review from a team July 8, 2022 22:25
@filterpaper filterpaper mentioned this pull request Jul 11, 2022
Merged
14 tasks
@zvecr zvecr merged commit 05f30f0 into qmk:develop Jul 20, 2022
@filterpaper filterpaper deleted the pm2040-i2c2-pins branch July 20, 2022 20:44
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@filterpaper @nolanseaton
Use Pro Micro pinout for SDA/SCL (qmk#17595)
227250b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @zvecr