Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More DD encoder fixes #17615

Merged
merged 1 commit into from
Jul 11, 2022
Merged

More DD encoder fixes #17615

merged 1 commit into from
Jul 11, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 10, 2022

Description

Fixes for:

  • case where resolution is not specified at all
    • should allow where keymaps currently specify value without undef

Might get there eventually....:cry:

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Jul 10, 2022
@zvecr zvecr requested a review from a team July 10, 2022 21:34
@github-actions github-actions bot added cli qmk cli command python labels Jul 10, 2022
@zvecr zvecr merged commit 35d78aa into qmk:develop Jul 11, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants