Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirque circular scroll: Support POINTING_DEVICE_COMBINED #17654

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Cirque circular scroll: Support POINTING_DEVICE_COMBINED #17654

merged 2 commits into from
Jul 26, 2022

Conversation

dkao
Copy link
Contributor

@dkao dkao commented Jul 13, 2022

Adjust coordinates for circular scroll, handle POINTING_DEVICE_ROTATION_*_RIGHT appropriately.

Description

Reuse pointing_device_adjust_by_defines*() instead of using an incomplete custom implementation of the same logic.
Fix pointing_device_adjust_by_defines_right() for 180 & 270 degrees.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 13, 2022
@dkao dkao mentioned this pull request Jul 13, 2022
Merged
14 tasks
@dkao dkao force-pushed the circular_scroll_POINTING_DEVICE_COMBINED branch from e2cfab2 to d89211f Compare July 13, 2022 07:15
KarlK90
KarlK90 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@KarlK90 KarlK90 requested review from drashna and a team July 13, 2022 15:20
dkao added 2 commits July 23, 2022 10:54
@dkao
pointing_device: Fix POINTING_DEVICE_ROTATION_*_RIGHT
89b661e
@dkao
circular scroll: Rotate coordinates based on user configuration
fe0a0de 
Change scale to +/-127 in case of -(-128) overflow.
Handle scroll axis for POINTING_DEVICE_COMBINED.
@dkao dkao force-pushed the circular_scroll_POINTING_DEVICE_COMBINED branch from d89211f to fe0a0de Compare July 23, 2022 18:16
@dkao
Copy link
Contributor Author

dkao commented Jul 23, 2022

Rebased

@drashna drashna merged commit 1de6811 into qmk:develop Jul 26, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@dkao @nolanseaton
Cirque circular scroll: Support POINTING_DEVICE_COMBINED (qmk#17654)
c76e041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkao @drashna @KarlK90