Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid OOB in dynamic_keymap_reset #17695

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 16, 2022

Description

Various via keymaps are currently configured with incorrect amounts of keymap layers (45_ats:via, 10bleoledhub:via, etc).

Instead of a _Static_assert in keymap introspection to ensure keymap layers == dynamic keymap layer count....

  • allow fewer keymap layers
    • will allow a small amount to be shaved off total firmware size
  • most layers are "empty" anyway
    • why bother having to maintain 2+ layers full of _______

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 16, 2022 01:57
@github-actions github-actions bot added the core label Jul 16, 2022
@zvecr zvecr marked this pull request as draft July 16, 2022 02:06
@zvecr zvecr force-pushed the feature/dkm_reset_oob branch from c2ad2a4 to d876bc9 Compare July 16, 2022 02:35
@zvecr zvecr marked this pull request as ready for review July 16, 2022 14:45
@drashna drashna requested a review from a team July 16, 2022 20:23
@zvecr zvecr merged commit c982d6c into qmk:develop Jul 26, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants