Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dynamic keymap to compile without via.h #17703

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Allow dynamic keymap to compile without via.h #17703

merged 1 commit into from
Jul 18, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 16, 2022

Description

Reduces the coupling slightly so that other features do not pull in via assumptions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the core label Jul 16, 2022
@zvecr zvecr requested a review from a team July 16, 2022 23:13
@zvecr zvecr merged commit 42eff8c into qmk:develop Jul 18, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Allow dynamic keymap to compile without via.h (qmk#17703)
2e0c03d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc