Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Use correct angle tune range of +/-127 on PMW33XX #17708

Merged
merged 1 commit into from
Jul 17, 2022
Merged

[Core] Use correct angle tune range of +/-127 on PMW33XX #17708

merged 1 commit into from
Jul 17, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 17, 2022

Description

...partially reverts 580bcff as the datasheet doesn't claim that the angle tuning as limited to +/- 30 degrees.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
Use correct angle tune range of +/-127 on PMW33XX
0221311 
...partially reverts 580bcff as the
datasheet doesn't claim that the angle tuning as limited to +/- 30
degrees.
@KarlK90 KarlK90 requested a review from a team July 17, 2022 18:54
@drashna drashna requested a review from a team July 17, 2022 18:56
@drashna
Copy link
Member

drashna commented Jul 17, 2022 •
edited
Loading

Yeah, I fell for this, initially too. The datasheet is not clear about this, at all, and leaves a lot of room for interpretation.

That said, I have confirmed previously that -127 to 127 works for the pmw3360 and is respected in the report from the firmware.

@KarlK90 KarlK90 merged commit a304a9b into qmk:develop Jul 17, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
Use correct angle tune range of +/-127 on PMW33XX (qmk#17708)
03e8ee7 
...partially reverts 580bcff as the
datasheet doesn't claim that the angle tuning as limited to +/- 30
degrees.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarlK90 @drashna @zvecr