Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix compilation issues for Charybdis/Dilemma #17791

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[Keyboard] Fix compilation issues for Charybdis/Dilemma #17791

merged 2 commits into from
Jul 26, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 25, 2022

Description

  • Print variables error in compilation, fixes.
  • Reduces amount of logging to just mouse related keycodes

Types of Changes

  • Bugfix
  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 25, 2022 18:18
@drashna drashna changed the title [Keyboard] Fix debug printing for Charybdis/Dilemma [Keyboard] Fix compilation issues for Charybdis/Dilemma Jul 25, 2022
@zvecr zvecr merged commit 928bbde into qmk:develop Jul 26, 2022
@drashna drashna deleted the keyboard/bastardkb_logging branch July 26, 2022 02:11
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@drashna @nolanseaton
[Keyboard] Fix compilation issues for Charybdis/Dilemma (qmk#17791)
0ce755e 
* [Keyboard] Fix debug printing for Charybdis/Dilemma

* Fix compliation issue for dilemma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @zvecr