Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain Cirque Pinnacle coordinates #17803

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Constrain Cirque Pinnacle coordinates #17803

merged 1 commit into from
Jul 26, 2022

Conversation

dkao
Copy link
Contributor

@dkao dkao commented Jul 26, 2022

Static x & y should be the same type as touchData.xValue & touchData.yValue: uint16_t.
Their delta could be larger than int8_t and should be constrained to mouse_xy_report_t.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dkao
Constrain Cirque Pinnacle coordinates
8c03fc6 
Static x & y should be the same type as touchData.xValue &
touchData.yValue: uint16_t.
Their delta could be larger than int8_t and should be constrained to
mouse_xy_report_t.
@github-actions github-actions bot added the core label Jul 26, 2022
@drashna drashna requested a review from a team July 26, 2022 15:40
@zvecr zvecr merged commit b8b2e99 into qmk:develop Jul 26, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@dkao @nolanseaton
Constrain Cirque Pinnacle coordinates (qmk#17803)
ec0dcb8 
Static x & y should be the same type as touchData.xValue &
touchData.yValue: uint16_t.
Their delta could be larger than int8_t and should be constrained to
mouse_xy_report_t.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkao @drashna @fauxpark @zvecr