Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bit-C PRO converter #17827

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Add Bit-C PRO converter #17827

merged 1 commit into from
Aug 13, 2022

Conversation

jaygreco
Copy link
Contributor

@jaygreco jaygreco commented Jul 28, 2022

Description

Add the nullbits Bit-C PRO RP2040 to the converters so that existing projects can be converted easily. Tested by converting a TIDBIT and crkbd and ensuring the resulting file flashed properly, booted with the Bit-C PRO flash, and worked as expected: no missing/swapped rows/columns, and underglow working.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jaygreco
Copy link
Contributor Author

BIt-C_PRO_pinout
Pinout attached for reference.

@drashna drashna requested review from zvecr and a team July 29, 2022 06:37
@tzarc tzarc requested a review from a team August 13, 2022 13:28
@zvecr zvecr merged commit 4eeafbe into qmk:develop Aug 13, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@jaygreco jaygreco deleted the add_bitc_pro_converter branch April 3, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants