Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecated check for RGBLIGHT_ANIMATIONS #17832

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Add deprecated check for RGBLIGHT_ANIMATIONS #17832

merged 2 commits into from
Aug 4, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 29, 2022 •
edited
Loading

Description

Adds a lint check for RGBLIGHT_ANIMATIONS, to start deprecating the define in favor of explicitly enabled animations

Types of Changes

  • Core

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 29, 2022 03:02
spidey3
spidey3 approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will definitely reduce confusion!

@drashna drashna requested a review from a team August 1, 2022 20:05
KarlK90
KarlK90 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna drashna merged commit eb417b3 into qmk:develop Aug 4, 2022
@drashna drashna deleted the lint/rgblight_all_animations branch August 4, 2022 18:05
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@drashna @nolanseaton
Add deprecated check for RGBLIGHT_ANIMATIONS (qmk#17832)
b85ef71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @KarlK90 @spidey3