-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Controller] Added board config for custom controller STeMCell (updated) #17870
Conversation
This pull request is based on the previous pull request by @Mariappan ( #16287 ) I have updated it to latest develop, and added a commit to support the changes to pindefs. I have tested on a few fingerpunch keyboards using the stemcell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been using this with a stemcell for the last week, without issue. RGB features and i2c pointing device included. EEPROM features appear to be working appropriately although have not tested VIA only lighting options.
The PR, I believe, addresses all the issues raised in the "stuck" PR #16287 , but I am unsure of the etiquette surrounding merging this ahead of the stuck PR.
Oh, just to explicitly note, some of the objections in the last PR were addressed by creating this feature: #16598 I am also leveraging this so we don't need to use the STMC=yes and can instead use the standardized CONVERT_TO=stemcell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes still fall under the same issues as #17711, where specifying the full board/chibos config files wants to be avoided.
For EEPROM, it would be to avoid STEMCELL_tinyuf2
linker script and be solved more generically for BOOTLOADER = tinyuf2
# ifndef SERIAL_USART_DRIVER | ||
# define SERIAL_USART_DRIVER SD2 | ||
# endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesnt belong in pin defs
# ifndef SERIAL_USART_DRIVER | |
# define SERIAL_USART_DRIVER SD2 | |
# endif |
|
||
#define I2C1_SCL_PIN D0 | ||
#define I2C1_SDA_PIN D1 | ||
#define FEE_PAGE_BASE_ADDRESS 0x08008000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesnt belong in pin defs
#define I2C1_SCL_PIN D0 | |
#define I2C1_SDA_PIN D1 | |
#define FEE_PAGE_BASE_ADDRESS 0x08008000 |
Co-authored-by: Joel Challis <git@zvecr.com>
For reference, I assume this conversation is relevant, so linking it here: I don't know enough about how this part of the codebase works, so deferring to @Mariappan to chime in. As a side note, I'm happy to contribute and/or fix myself, but some more detailed guidance would be very helpful! |
The EEPROM emulation should work with EEPROM_DRIVER = wear_leveling
WEAR_LEVELING_DRIVER = legacy (
Board config should be inherited from a ChibiOS definition, like in |
@Mariappan has started working on #16287 again, so I'll stop using this PR, and defer to that one. If it's okay, I'll keep this one open until that one gets merged in. But for now, this one is on pause. Please let me know if anyone has any objections to this. |
replaced by #16287 |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist