-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iris Rev. 7 #17967
Add Iris Rev. 7 #17967
Conversation
(cherry picked from commit 4a23360ad163716a5cf51c54de9e18bac58bcdd6)
(cherry picked from commit 153464d21f54feecdf5f9bf89152efdcd34659e4)
(cherry picked from commit 6ac11b23a2d7eff20aad38f5f6ab1f499bb1d358)
(cherry picked from commit 4e99ef4dfd8d950a352c51368fb18dff64ea9451)
(cherry picked from commit e5c99cb8936b9b26b82620423b04971cd33bd514)
(cherry picked from commit b9cadd8cd35c887c6936612473ffe3dc479b610f)
(cherry picked from commit 2f9e97dd55cebdab65287f6547b0f2942510dfc0)
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
|
||
#ifdef ENCODER_MAP_ENABLE | ||
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = { | ||
# if defined(KEYBOARD_keebio_iris_rev7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for some feedback here on if this is the right approach for handling differing numbers of encoders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there is a great way to handle this, aside from having the keymap folder in the different revision folders.
But this should be okay, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing shows lots of historical user keymaps with RGBmatrix issues, main keymaps (default, via, miryoku) all behave normally.
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Description
Adds support for Iris Rev. 7
Types of Changes
Issues Fixed or Closed by This PR
Checklist