KBDfans KBD67 rev2: rename LAYOUT_65_ansi_split_bs_2_right_mods macro #17972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
force-pushed
the
rf/kbdfans_kbd67_rev2
branch
from
eac52b3 to
78a91fb
Compare
fauxpark
approved these changes
Aug 10, 2022
drashna
approved these changes
Aug 11, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LAYOUT_65_ansi_split_bs_2_right_modstoLAYOUT_65_ansi_rwkl_split_bsI never liked the
_2_right_modsnotation even though it was my idea. Always thought it was kind of clumsy and awkward. Finally came up with this nomenclature.___forKC_NOinrev2.hrev2.hTypes of Changes
Checklist