Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CG_SWAP in junonum #18086

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Replace CG_SWAP in junonum #18086

merged 1 commit into from
Aug 17, 2022

Conversation

JunoNgx
Copy link
Contributor

@JunoNgx JunoNgx commented Aug 17, 2022

Description

  • Minor update for my personal keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

spidey3
spidey3 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zvecr zvecr merged commit 45845ea into qmk:master Aug 17, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@JunoNgx @imhoffman
Replace CG_SWAP in junonum (qmk#18086)
ab8dde3 
Co-authored-by: Minh-tri Nguyen <mtngx@PigeonMac.local>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@JunoNgx @nolanseaton
Replace CG_SWAP in junonum (qmk#18086)
9f8935b 
Co-authored-by: Minh-tri Nguyen <mtngx@PigeonMac.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunoNgx @zvecr @spidey3