-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pointing device support to data driven config #18215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, found a duplication in the mapping defines which seems bogus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ed133c8
to
3dfd539
Compare
data/mappings/info_config.json
Outdated
@@ -92,6 +103,7 @@ | |||
"SECURE_IDLE_TIMEOUT": {"info_key": "secure.idle_timeout", "value_type": "int"}, | |||
"SENDSTRING_BELL": {"info_key": "audio.macro_beep", "value_type": "bool"}, | |||
"SPLIT_MODS_ENABLE": {"info_key": "split.transport.sync_modifiers", "value_type": "bool"}, | |||
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this to fit into the transport
options - or how would you distinguish these here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, fair.
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"}, | |
"SPLIT_POINTING_ENABLE": {"info_key": "split.transport.sync_pointing", "value_type": "bool"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split.transport.sync_pointing_device
?
though I'm not sure what is actually synced - but all other options use _DEVICE_
as part of the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm horrible at naming...
Not sure if it's better to use the full "pointing device" as per the other features, or keep it closer to what the other transport.sync_* names are for consistency (with both naming in the info.json and config.h stuff)
d4ddf5d
to
a8b8679
Compare
Co-authored-by: Joel Challis <git@zvecr.com>
6ad0fd1
to
78619e5
Compare
This reverts commit d3073ef.
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
resurrected and squashed from qmk#18215
resurrected and squashed from qmk#18215
Description
First attempt at adding support for data driven config.
Types of Changes
Checklist