Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointing device support to data driven config #18215

Merged
merged 12 commits into from
Nov 13, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 30, 2022

Description

First attempt at adding support for data driven config.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Aug 30, 2022
@drashna drashna requested a review from a team August 30, 2022 06:14
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, found a duplication in the mapping defines which seems bogus.

data/schemas/keyboard.jsonschema Outdated Show resolved Hide resolved
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna drashna requested a review from a team August 30, 2022 20:20
@drashna drashna force-pushed the dd/pointing_device branch from ed133c8 to 3dfd539 Compare August 31, 2022 14:17
@@ -92,6 +103,7 @@
"SECURE_IDLE_TIMEOUT": {"info_key": "secure.idle_timeout", "value_type": "int"},
"SENDSTRING_BELL": {"info_key": "audio.macro_beep", "value_type": "bool"},
"SPLIT_MODS_ENABLE": {"info_key": "split.transport.sync_modifiers", "value_type": "bool"},
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this to fit into the transport options - or how would you distinguish these here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, fair.

Suggested change
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"},
"SPLIT_POINTING_ENABLE": {"info_key": "split.transport.sync_pointing", "value_type": "bool"},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split.transport.sync_pointing_device ?
though I'm not sure what is actually synced - but all other options use _DEVICE_ as part of the name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm horrible at naming...

Not sure if it's better to use the full "pointing device" as per the other features, or keep it closer to what the other transport.sync_* names are for consistency (with both naming in the info.json and config.h stuff)

@drashna drashna requested a review from a team September 17, 2022 17:30
lib/python/qmk/cli/generate/config_h.py Outdated Show resolved Hide resolved
@tzarc tzarc merged commit d3073ef into qmk:develop Nov 13, 2022
@drashna drashna deleted the dd/pointing_device branch November 13, 2022 18:12
drashna added a commit to drashna/qmk_firmware that referenced this pull request Nov 13, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@Kriechi Kriechi mentioned this pull request Jan 25, 2023
14 tasks
Kriechi pushed a commit to Kriechi/qmk_firmware that referenced this pull request Apr 17, 2023
@Kriechi Kriechi mentioned this pull request Aug 5, 2023
14 tasks
Kriechi pushed a commit to Kriechi/qmk_firmware that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants