Work around WinCompose issue for U+Axxx or U+Exxx #18260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a Windows machine handy to test this, but in theory it should work. |
sigprof
reviewed
Sep 4, 2022
spidey3
force-pushed
the
winc_unicode_workaround
branch
from
db40d8c to
09a05e8
Compare
spidey3
force-pushed
the
winc_unicode_workaround
branch
from
09a05e8 to
9cc0894
Compare
|
I've rebased and re-pointed this at the |
|
I can see about testing this on a windows machine this week |
zvecr
approved these changes
Sep 16, 2022
spidey3
force-pushed
the
winc_unicode_workaround
branch
from
9cc0894 to
71e733f
Compare
|
I've picked up @tzarc's suggested simplification. |
tzarc
approved these changes
Sep 18, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
* Work around WinCompose issue for U+Axxx or U+Exxx * tzarc's more efficient version Co-authored-by: Thomas <mail@tpreisner.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AtlasTheGarbage said:
This works around that problem by prepending a 0 in
UC_WINCif the code begins with A-F, as the problem does not occur if a leading zero is added (U+0Axxx or U+0Exxx).Types of Changes
Issues Fixed or Closed by This PR
Checklist