Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise LAYOUT macro generation #18262

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Optimise LAYOUT macro generation #18262

merged 1 commit into from
Sep 19, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 4, 2022 •
edited
Loading

Description

  • Avoid LAYOUT macros injected into every compilation unit
  • Avoid generating an extra file
    • One less round trip resolving info.json

Future

  • Use entrypoint for keymap specific includes
    • Current example avoids legacy keycodes from being used in core (will be PRed separately)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python and removed core labels Sep 4, 2022
@zvecr zvecr marked this pull request as ready for review September 4, 2022 01:03
@zvecr zvecr requested a review from a team September 4, 2022 01:03
@zvecr zvecr changed the title Tidy up LAYOUT macro generation Optimise LAYOUT macro generation Sep 7, 2022
@zvecr zvecr force-pushed the feature/tidy_layout_gen branch from f479cfb to 03b57bd Compare September 19, 2022 00:27
@zvecr zvecr merged commit 20f142a into qmk:develop Sep 19, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Tidy up LAYOUT macro generation (qmk#18262)
e24f792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command keyboard optimization python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @fauxpark